Review 10.4 Merged

70557[BUGFIX] Use loading="lazy" in FormEngineUtility::getIconHtml()

Andreas Kienast CR +2 V +2 Easy +1 −0 updated 08/14/21, 10:43

Commit message

The method `FormEngineUtility::getIconHtml()` is used in various places,
e.g. when rendering icons of a SelectIcons field wizard. If many icons
are loaded, the rendering process may take some time, depending on the
user's internet connection. To improve the initial rendering speed, the
icons are now lazy loaded.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Andreas Kienast commented on patch set 1 08/14/21, 10:22

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 08/14/21, 10:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15052

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/14/21, 10:43

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/14/21, 10:43

  5. Andreas Kienast merged patch set 2 08/14/21, 10:43