Review 10.4 Merged

70781[TASK] Add support for class-string annotation and provide meta file

Andreas Kienast CR +2 V +2 Normal +121 −66 updated 09/04/21, 15:59

Commit message

PhpStorm has basic support for generics since version 2021.2 which comes
in handy as since the same version the "Dynamic Return Type" plugin is broken.

Providing the class-string annotation and a proper return generic
supersedes this and recovers the built-in autocompletion.

To have the same effect for both, 3rd party code not being under our
control or methods having complex returns based on their input, a
`.phpstorm.meta.php` file is provided extending PhpStorms code awareness
capabilities.
Tons of kudos to Alexander Schnitzler providing a boilerplate
configuration here:
https://github.com/alexanderschnitzler/phpstorm.meta.php-typo3

For more information about capability extension consult
https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 711

  1. Andreas Kienast commented on patch set 1 09/04/21, 15:12

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Utility/GeneralUtility.php * typo3/sysext/extbase/Classes/Object/Container/Container.php
  2. Andreas Kienast uploaded patch set 2 09/04/21, 15:14

  3. Andreas Kienast marked it ready for review 09/04/21, 15:16

  4. core-ci voted on patch set 1 V -1 09/04/21, 15:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16254

  5. core-ci voted on patch set 2 V -1 09/04/21, 15:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16255

  6. Andreas Kienast uploaded patch set 3 09/04/21, 15:27

  7. Andreas Kienast uploaded patch set 4 09/04/21, 15:34

  8. core-ci voted on patch set 3 V +1 09/04/21, 15:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16258

  9. core-ci voted on patch set 4 V +1 09/04/21, 15:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16263

  10. Andreas Kienast voted on patch set 4 V +2 CR +2 09/04/21, 15:58

  11. Andreas Kienast merged patch set 5 09/04/21, 15:59