Review 10.4 Merged

71056[BUGFIX] Respect includeNotInMenu setting in menu cache hash

Georg Ringer CR +2 V +2 Easy +1 −1 updated 09/13/21, 18:31

Commit message

isSubmenu() produces different results depending on the
includeNotInMenu setting, Therefore we need to use separate
cache entries.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 09/13/21, 18:10

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 09/13/21, 18:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16673

  3. Georg Ringer voted on patch set 1 V +2 CR +2 09/13/21, 18:31

  4. Georg Ringer merged patch set 2 09/13/21, 18:31