Review 10.4 Merged

71057[TASK] Make some type annotations more specific

Oliver Klee CR +2 V +2 Easy +10 −6 updated 09/14/21, 14:15

Commit message

This change helps static code analyzers like PHPStan or Psalm.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Oliver Klee commented on patch set 1 09/14/21, 12:05

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Localization/LocalizationFactory.php * typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php
  2. core-ci voted on patch set 1 V +1 09/14/21, 12:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16697

  3. Oliver Klee uploaded patch set 2 09/14/21, 12:46

  4. Oliver Klee marked it ready for review 09/14/21, 12:46

  5. Oliver Klee voted on patch set 2 V +1 CR +1 09/14/21, 12:46

  6. core-ci voted on patch set 2 V +1 09/14/21, 12:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16699

  7. Oli Bartsch updated the commit message in patch set 3 09/14/21, 13:48

  8. Oli Bartsch commented on patch set 3 V +2 CR +2 09/14/21, 13:49

    Will merge one CI is green.
  9. Oliver Klee voted on patch set 3 V +1 CR +1 09/14/21, 13:49

  10. core-ci voted on patch set 3 V +1 09/14/21, 13:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16706

  11. Oli Bartsch merged patch set 4 09/14/21, 14:15