Review 10.4 Abandoned

71355[BUGFIX] Fix the generics annotations for ObjectManager(Interface)

Oliver Klee CR 0 V 0 Normal +36 −26 updated 10/06/21, 15:50

Commit message

To avoid PHPStan warnings in projects that use ObjectManagerInterface
as a type annotation, the ObjectManager(Interface) generics need to
be on the generating methods, not on the class/interface itself.

Also streamline the PHPDoc to be more consistent, and fix the semantics
(there are no object instances, only class instances) to avoid
confusing the reader.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 79

  1. Oliver Klee commented on patch set 1 10/04/21, 12:33

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Object/ObjectManager.php * typo3/sysext/extbase/Classes/Object/ObjectManagerInterface.php
  2. core-ci voted on patch set 1 V -1 10/04/21, 12:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17554

  3. Oliver Klee uploaded patch set 2 10/04/21, 13:08

  4. Oliver Klee marked it ready for review 10/04/21, 13:09

  5. core-ci voted on patch set 2 V +1 10/04/21, 13:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17555

  6. Helmut Hummel voted on patch set 2 V +1 CR +1 10/06/21, 14:12

  7. Christian Kuhn commented on patch set 2 10/06/21, 14:15

    why is the Change-Id different from the master version?
  8. Oliver Klee abandoned the change 10/06/21, 14:42

  9. Oliver Klee commented on patch set 2 10/06/21, 15:50