Review 10.4 Merged

71359[BUGFIX] Rebuild redirect cache after changing slug

Benni Mack CR +2 V +2 Easy +1 −0 updated 10/08/21, 06:54

Commit message

If a slug is changed, the redirect cache must be rebuilt to make
the redirect actually work.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack commented on patch set 1 10/07/21, 14:11

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 10/07/21, 14:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17751

  3. Benjamin Franzke commented on patch set 1 10/07/21, 14:43

    SlugService.php:142

    RedirectCacheService is a small service so it seems fine to be always injected in constructor, right? Or does that require too many tests to be adapted?
  4. Benjamin Franzke commented on patch set 1 10/07/21, 14:44

    SlugService.php:142 Reply

    Ah, sorry, saw you already mentioned that in the main patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70461/2#message-b24b61a919674d07ee0c449fb880d5078e43e36e So its too late and something for a separate patch, nevermind.
  5. Benni Mack commented on patch set 1 10/07/21, 14:45

    SlugService.php:142 Reply Unresolved

    no. I asked the same question in the original change, but was too lazy to change this, but took this for v10 as "works", and let's improve it in the next iteration for master (DataHandler change) in v11/master only.
  6. Benni Mack voted on patch set 1 V +2 CR +2 10/08/21, 06:54

  7. Benni Mack merged patch set 2 10/08/21, 06:54