71362[BUGFIX] access-restricted subpages of sysfolders return 403
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 4
Files 5
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php2+17 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml+6 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+6 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php2+177 −39
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+214 −0
Review log 912
-
Benni Mack commented on patch set 1 10/10/21, 18:24
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php -
core-ci voted on patch set 1 V -1 10/10/21, 18:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17902
-
Benni Mack uploaded patch set 2 10/13/21, 14:44
-
Benni Mack marked it ready for review 10/13/21, 14:44
-
core-ci voted on patch set 2 V -1 10/13/21, 14:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18054
-
Stefan Bürk uploaded patch set 3 10/13/21, 16:59
-
core-ci voted on patch set 3 V +1 10/13/21, 17:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18063
-
Stefan Bürk commented on patch set 3 10/13/21, 17:14
TypoScriptFrontendController.php:1412This is a new v11 class, used ImmediateResponseException for backport. Adapted from block below, where it was adapted from in v11 too.SiteRequestTest.php:570Changed executeFrontendSubRequest() [v11] to executeFrontendRequest() [v10] (on several places) -
Stefan Bürk voted on patch set 3 CR +1 10/13/21, 17:23
-
Stefan Bürk voted on patch set 3 V +1 10/13/21, 17:29
-
Benni Mack commented on patch set 3 V +2 CR +2 10/13/21, 19:21
TypoScriptFrontendController.php:1412Replyaaargh. could have checked that! thanks!SiteRequestTest.php:570ReplySame here! -
Benni Mack merged patch set 4 10/13/21, 19:21