Review 10.4 Merged

71362[BUGFIX] access-restricted subpages of sysfolders return 403

Benni Mack CR +2 V +2 Hard +420 −41 updated 10/13/21, 19:21

Commit message

This change addresses a regression of
https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829
where access-restricted pages (e.g. fe_groups restriction) under
a sys-folder (e.g. 2021 for subpages categorized by the sys-folder 2020)
to again return a 403 error to be properly handled by a proper
error handler.

This change adds tests to ensure this functionality is always working.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 5

Review log 912

  1. Benni Mack commented on patch set 1 10/10/21, 18:24

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php
  2. core-ci voted on patch set 1 V -1 10/10/21, 18:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17902

  3. Benni Mack uploaded patch set 2 10/13/21, 14:44

  4. Benni Mack marked it ready for review 10/13/21, 14:44

  5. core-ci voted on patch set 2 V -1 10/13/21, 14:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18054

  6. Stefan Bürk uploaded patch set 3 10/13/21, 16:59

  7. core-ci voted on patch set 3 V +1 10/13/21, 17:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18063

  8. Stefan Bürk commented on patch set 3 10/13/21, 17:14

    TypoScriptFrontendController.php:1412

    This is a new v11 class, used ImmediateResponseException for backport. Adapted from block below, where it was adapted from in v11 too.

    SiteRequestTest.php:570

    Changed executeFrontendSubRequest() [v11] to executeFrontendRequest() [v10] (on several places)
  9. Stefan Bürk voted on patch set 3 CR +1 10/13/21, 17:23

  10. Stefan Bürk voted on patch set 3 V +1 10/13/21, 17:29

  11. Benni Mack commented on patch set 3 V +2 CR +2 10/13/21, 19:21

    TypoScriptFrontendController.php:1412 Reply

    aaargh. could have checked that! thanks!

    SiteRequestTest.php:570 Reply

    Same here!
  12. Benni Mack merged patch set 4 10/13/21, 19:21