Review 10.4 Merged

71577[BUGFIX] Fix page link in redirects module pagination

Benni Mack CR +2 V +2 Easy +5 −3 updated 10/13/21, 14:53

Commit message

With this patch, the page link (requesting a
dedicated paginated page) in the redirects module
pagination is now working again. This is done
by accessing the target from the corresponding
event, since it's not forwarded as method
argument.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Benni Mack commented on patch set 1 10/13/21, 14:29

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/redirects/Resources/Public/TypeScript/RedirectsModule.ts * typo3/sysext/redirects/Resources/Public/JavaScript/RedirectsModule.js
  2. Benni Mack uploaded patch set 2 10/13/21, 14:32

  3. Benni Mack uploaded patch set 3 10/13/21, 14:34

  4. Benni Mack marked it ready for review 10/13/21, 14:34

  5. core-ci voted on patch set 1 V -1 10/13/21, 14:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18050

  6. core-ci voted on patch set 2 V +1 10/13/21, 14:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18051

  7. core-ci voted on patch set 3 V +1 10/13/21, 14:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18052

  8. Benni Mack voted on patch set 3 V +2 CR +2 10/13/21, 14:53

  9. Benni Mack merged patch set 4 10/13/21, 14:53