Review 10.4 Merged

71578[BUGFIX] Ensure routing works for request with chinese letter

Benni Mack CR +2 V +2 Hard +296 −2 updated 10/14/21, 06:11

Commit message

Routing for requests with chinese letters failed. As the used
symfony components internally uses rawlurldecode() on some
places, but this was not done reading from site configuration
and reparing route collection, this has been lead to 404
instead of correct page matchings.

This patch uses rawurldecode() to prepare route paths correctly
for chinese letters and introduce tests to cover these cases.

Furthermore it adds some todo's which are out of the scope
for this patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 810

  1. Benni Mack commented on patch set 1 10/13/21, 19:19

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 10/13/21, 19:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18072

  3. Stefan Bürk uploaded patch set 2 10/13/21, 19:33

  4. Stefan Bürk commented on patch set 2 10/13/21, 19:39

    Changed for backport: * executeFrontendSubRequest()[v11] => executeFrontendRequest()[v10] * removed expected redirect header which was added in v11 (see line comment)

    SlugSiteRequestTest.php:262

    That header was added somewhere in v11, v10 do not add that header. Removed for backport.
  5. core-ci voted on patch set 2 V +1 10/13/21, 19:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18073

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/13/21, 19:45

  7. Oli Bartsch voted on patch set 2 CR +1 10/13/21, 19:59

  8. Benni Mack voted on patch set 2 V +2 CR +2 10/14/21, 06:10

  9. Benni Mack merged patch set 3 10/14/21, 06:10

  10. Benni Mack commented on patch set 3 10/14/21, 06:11

    Reply

    Ack

    SlugSiteRequestTest.php:262 Reply

    Ack