71578[BUGFIX] Ensure routing works for request with chinese letter
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+5 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml+8 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+8 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+2 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+117 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+5 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php2+151 −0
Review log 810
-
Benni Mack commented on patch set 1 10/13/21, 19:19
Cherry Picked from branch master. -
core-ci voted on patch set 1 V -1 10/13/21, 19:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18072
-
Stefan Bürk uploaded patch set 2 10/13/21, 19:33
-
Stefan Bürk commented on patch set 2 10/13/21, 19:39
Changed for backport: * executeFrontendSubRequest()[v11] => executeFrontendRequest()[v10] * removed expected redirect header which was added in v11 (see line comment)SlugSiteRequestTest.php:262That header was added somewhere in v11, v10 do not add that header. Removed for backport. -
core-ci voted on patch set 2 V +1 10/13/21, 19:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18073
-
Stefan Bürk voted on patch set 2 V +1 CR +1 10/13/21, 19:45
-
Oli Bartsch voted on patch set 2 CR +1 10/13/21, 19:59
-
Benni Mack voted on patch set 2 V +2 CR +2 10/14/21, 06:10
-
Benni Mack merged patch set 3 10/14/21, 06:10