Review 10.4 Merged

71854[BUGFIX] Ensure slug pieces are strings

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/19/21, 14:30

Commit message

Pieces assembled into slugs must be strings.
The pieces may stem from any database field.
Depending on the database driver the data type
may vary, so always cast them to string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn commented on patch set 1 10/19/21, 14:13

    Cherry Picked from branch master.
  2. Jochen Roth voted on patch set 1 V +1 CR +1 10/19/21, 14:14

  3. core-ci voted on patch set 1 V +1 10/19/21, 14:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18319

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 10/19/21, 14:30

  5. Christian Kuhn merged patch set 2 10/19/21, 14:30