Review 10.4 Merged

71915[BUGFIX] Avoid passing null as parameter to trim()

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/23/21, 22:00

Commit message

To make units test notice free in #85092 a wrong
fallback for array access has been used.

Fallback to null and passing to trim() through
null coalescing operator has been the wrong choice,
as it triggers a deprecation message in PHP 8.1.

This patch change the fallback to an empty string
instead to avoid this deprecation message.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 10/23/21, 21:29

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 10/23/21, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18471

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/23/21, 22:00

  4. Christian Kuhn merged patch set 2 10/23/21, 22:00