Review 10.4 Merged

71916[BUGFIX] Use correct return type annotations in validation results

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 10/24/21, 15:58

Commit message

Three methods in Extbase's Result are now
annotated with the correct return type to
make PHPStan happy when they are accessed
in custom extensions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 10/24/21, 15:40

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 10/24/21, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18502

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/24/21, 15:58

  4. Christian Kuhn merged patch set 2 10/24/21, 15:58