71926[BUGFIX] Do not HTML encode attributes in Script and Asset VH
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php+29 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php+30 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/CssViewHelperTest.phpnew+85 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/ScriptViewHelperTest.phpnew+83 −0
Review log 69
-
Benni Mack commented on patch set 1 11/05/21, 11:32
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/ScriptViewHelperTest.php -
Benni Mack commented on patch set 2 11/05/21, 11:32
Published edit on patch set 1. -
Benni Mack marked it ready for review 11/05/21, 11:32
-
core-ci voted on patch set 1 V -1 11/05/21, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18942
-
core-ci voted on patch set 2 V -1 11/05/21, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18943
-
Benni Mack uploaded patch set 3 11/05/21, 11:40
-
core-ci voted on patch set 3 V +1 11/05/21, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18946
-
Benni Mack voted on patch set 3 V +2 CR +2 11/05/21, 11:54
-
Benni Mack merged patch set 4 11/05/21, 11:54