Review 10.4 Merged

72117[BUGFIX] Fix loose type check in BackendUserAuthentication

Benjamin Franzke CR +2 V +2 Easy +1 −4 updated 11/15/21, 19:05

Commit message

empty() returns true if a record contains 0 as value.
Therefore isset() needs to be used instead.

The corresponding fix that was introduced with #91145
to workaround this flaw is removed again.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/15/21, 16:46

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/15/21, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19307

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 11/15/21, 19:04

  4. Benjamin Franzke merged patch set 2 11/15/21, 19:05