Review 10.4 Merged

72120[BUGFIX] Allow slashes as TS keys and escape dots for generated TS

Helmut Hummel CR +2 V +2 Normal +219 −8 updated 12/13/21, 17:17

Commit message

With the introduction of site settings being exposed
to TypoScript with https://review.typo3.org/64128
it has become important to allow more characters
as TypoScript keys. Allowing a slash in addition should
cover cases where paths are exposed as keys.

Additionally the above change reveals, that the
ArrayUtility::flatten method does not properly handle
array keys that has dots in between, as those must
be escaped to produce a correct result.

This change introduces a new flatten method after
several failed attempts to guess what fixes might
not be breaking.

The new method is used in places where no TypoScript
is used, as in those the weird edge case behaviour
of the flatten method isn't expected anyway.

The new method is marked internal until it is decided
how to proceed with the flatten method.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 69

  1. Helmut Hummel commented on patch set 1 11/17/21, 10:15

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php
  2. core-ci voted on patch set 1 V -1 11/17/21, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19393

  3. Helmut Hummel commented on patch set 2 11/17/21, 10:18

    Published edit on patch set 1.
  4. Helmut Hummel marked it ready for review 11/17/21, 10:20

  5. core-ci voted on patch set 2 V -1 11/17/21, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19394

  6. Helmut Hummel uploaded patch set 3 12/13/21, 16:09

  7. core-ci voted on patch set 3 V +1 12/13/21, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21038

  8. Helmut Hummel voted on patch set 3 V +2 CR +2 12/13/21, 17:16

  9. Helmut Hummel merged patch set 4 12/13/21, 17:17