Review 11.5 Merged

72255[BUGFIX] Trigger modal dismiss on cancel

Oli Bartsch CR +2 V +2 Easy +5 −2 updated 11/22/21, 10:57

Commit message

Currently when a language in site configuration
is removed the modal cancel button does not
remove/cancel the modal.

This has been fixed by adding a trigger to close
the modal when the cancel button was clicked.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Oli Bartsch commented on patch set 1 11/22/21, 09:11

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 11/22/21, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19627

  3. core-ci voted on patch set 1 V +1 11/22/21, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19627

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 11/22/21, 10:57

  5. Oli Bartsch merged patch set 2 11/22/21, 10:57