Review 11.5 Merged

72256[BUGFIX] Ignore prefixParentPageSlug for non-page record in SlugHelper

Oli Bartsch CR +2 V +2 Easy +47 −1 updated 11/22/21, 16:05

Commit message

TCA slug field generator option 'prefixParentPageSlug' has been added
to be used for page records only. Slug generation for non-page records
with pid=0 has been fixed with #94655 which introduced a endless loop
if 'prefixParentPageSlug' is used as slug field generator option for
record tables.

This patch only process 'prefixParentPageSlug' for page records, thus
ignoring it for non-page records and avoiding the endlees loop and as
such prevent segmentation faults or memory_limit fatal errors.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 11/22/21, 15:50

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/22/21, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19639

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 11/22/21, 16:05

  4. Oli Bartsch merged patch set 2 11/22/21, 16:05