Review 11.5 Merged

72261[TASK] Avoid inline JavaScript in backend update signals

Oli Bartsch CR +2 V +2 Normal +159 −13 updated 11/23/21, 10:17

Commit message

BackendUtility::getUpdateSignalCode() returned plain inline JavaScript
code which got replaced by new BackendUtility::getUpdateSignalDetails().

The new function is capable of handling inline JavaScript code (for
backward compatibility reasons) and HTML markup using corresponding
`<typo3-immediate-action>` custom element.

OpendocsToolbarItem::updateNumberOfOpenDocsHook has been adjusted as
well to use the script-less implementation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 11

Review log 56

  1. Oli Bartsch commented on patch set 1 11/23/21, 09:58

    Cherry Picked from branch master.
  2. Oliver Hader wrote 11/23/21, 09:59

    Topic inline-javascript-11.5 removed
  3. Oliver Hader wrote 11/23/21, 09:59

    Topic set to inline-javascript
  4. core-ci voted on patch set 1 V +1 11/23/21, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19665

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 11/23/21, 10:17

  6. Oli Bartsch merged patch set 2 11/23/21, 10:17