72262[TASK] Avoid inline JavaScript in DispatchNotificationHook
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
-
Verified V +2 Done
- Oli Bartsch +2
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/redirects/Resources/Public/TypeScript/EventHandler.ts+5 −0
- typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php+23 −0
- typo3/sysext/core/Resources/Public/JavaScript/JavaScriptHandler.js+4 −2
- typo3/sysext/redirects/Classes/Hooks/DispatchNotificationHook.php+12 −9
- typo3/sysext/redirects/Resources/Public/JavaScript/EventHandler.js+1 −1
Review log 56
-
Oli Bartsch commented on patch set 1 11/23/21, 12:38
Cherry Picked from branch master. -
Oliver Hader wrote 11/23/21, 12:38
Topic inline-javascript-11.5 removed -
Oliver Hader wrote 11/23/21, 12:38
Topic set to inline-javascript -
core-ci voted on patch set 1 V +1 11/23/21, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19673
-
Oli Bartsch voted on patch set 1 V +2 CR +2 11/23/21, 12:51
-
Oli Bartsch merged patch set 2 11/23/21, 12:51