Review 11.5 Merged

72265[BUGFIX] Observe GridEditor visibility to refresh codeMirror

Oli Bartsch CR +2 V +2 Easy +22 −1 updated 11/24/21, 21:17

Commit message

In case a TCA field with renderType=belayoutwizard
is configured to be not in the initially visible tab, the
CodeMirror editor remains empty, when switching to
the tab, containing the editor. The reason is, CodeMirror
needs to be refreshed, after becoming visible.

Therefore, the GridEditor, holding the configuration,
is now observed, if not initially visible. As soon as it
becomes visible, the CodeMirror instance - if any -
is refreshed.

Can be tested with `tx_styleguide_elements_basic.text_20`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Oli Bartsch commented on patch set 1 11/24/21, 18:35

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 11/24/21, 18:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19709

  3. core-ci voted on patch set 1 V +1 11/24/21, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19709

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 11/24/21, 21:17

  5. Oli Bartsch merged patch set 2 11/24/21, 21:17