Review 11.5 Merged

72293[TASK] Avoid setting assertCleanReferenceIndex to false in tests

Christian Kuhn CR +2 V +2 Hard +184 −76 updated 11/25/21, 13:59

Commit message

Functional tests that extend AbstractDataHandlerActionTestCase
test for correct sys_refindex in tearDown(). This can
be avoided by setting assertCleanReferenceIndex to false,
which is only a temporary solution until reference updating
fully works.

The patch changes some import fixtures that come without
proper sys_refindex rows to avoid setting this property
to false.

One last call needs a dedicated bug fix and will have a
dedicated patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 13

Review log 34

  1. Christian Kuhn commented on patch set 1 11/25/21, 13:38

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/25/21, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19738

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 11/25/21, 13:59

  4. Christian Kuhn merged patch set 2 11/25/21, 13:59