Review 11.5 Merged

72297[BUGFIX] Update CSV references when discarding record

Christian Kuhn CR +2 V +2 Normal +90 −15 updated 11/25/21, 22:01

Commit message

When an element is discarded in workspaces that is referenced
by another record in a group CSV field, those referencing
records need to be updated to no longer list the discarded
record.

The patch adds a method to DataHandler discard logic to
take care of that.

This resolves the very last call setting assertCleanReferenceIndex
to false. That test property has been a temporary solution and
is dropped now, tests extending AbstractDataHandlerActionTestCase
can no longer (easily) prevent the tearDown() refindex check and
should never do that again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 34

  1. Christian Kuhn commented on patch set 1 11/25/21, 21:34

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/25/21, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19768

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 11/25/21, 22:01

  4. Christian Kuhn merged patch set 2 11/25/21, 22:01