Review 11.5 Merged

72306[TASK] Streamline DataHandler functional tests

Andreas Kienast CR +2 V +2 Nightmare +1168 −1754 updated 11/27/21, 20:13

Commit message

* Obsolete importScenarioDataSet() by using
  importCSVDataSet() directly with absolute paths.
  IDE's now resolve these paths so they can be
  clicked to open, which is *much* more convenient
  when working with the .csv files.
* Similar, obsolete assertAssertionDataSet() by using
  assertCSVDataSet() directly.
* Protected constants.
* Late static binding for workspace init in setUp()
  to simplify and streamline workspace test inheritance.
* A couple of minor streamlinings.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 84

Show 64 more files

Review log 57

  1. Andreas Kienast commented on patch set 1 11/27/21, 18:14

    Cherry Picked from branch master.
  2. Christian Kuhn commented on patch set 1 CR -1 11/27/21, 18:21

    this has to be done on-top of a TF raise+tag - the assertCSVDataSet() method otherwise does not work as expected. let's let this backport rot a small while until this is done.
  3. core-ci voted on patch set 1 V -1 11/27/21, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19885

  4. Christian Kuhn rebased onto patch set 2 11/27/21, 19:46

  5. core-ci voted on patch set 2 V +1 11/27/21, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19893

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 11/27/21, 20:12

  7. Andreas Kienast merged patch set 3 11/27/21, 20:13