72306[TASK] Streamline DataHandler functional tests
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
-
Verified V +2 Done
- Andreas Kienast +2
- core-ci +1 CI
Issues 1
Files 84
- typo3/sysext/backend/Tests/Functional/Controller/Page/LocalizationControllerTest.php+7 −14
- typo3/sysext/core/Tests/Functional/DataHandling/Category/ManyToMany/Modify/ActionTest.php+13 −18
- typo3/sysext/core/Tests/Functional/DataHandling/Category/ManyToMany/AbstractActionTestCase.php+2 −5
- typo3/sysext/core/Tests/Functional/DataHandling/Category/OneToMany/Modify/ActionTest.php+13 −18
- typo3/sysext/core/Tests/Functional/DataHandling/Category/OneToMany/AbstractActionTestCase.php+3 −6
- typo3/sysext/core/Tests/Functional/DataHandling/Category/OneToOne/Modify/ActionTest.php+10 −15
- typo3/sysext/core/Tests/Functional/DataHandling/Category/OneToOne/AbstractActionTestCase.php+3 −6
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DefaultValuesTest.php+3 −11
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DeleteTranslatedSubpagesTest.php+1 −6
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/GetUniqueTranslationTest.php+3 −11
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/HookTest.php+9 −14
- typo3/sysext/core/Tests/Functional/DataHandling/DataResolving/PlainDataResolverTest.php+1 −6
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/ActionTest.php+14 −19
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/AbstractActionTestCase.php+21 −24
- typo3/sysext/core/Tests/Functional/DataHandling/Flexform/ActionTest.php+5 −9
- typo3/sysext/core/Tests/Functional/DataHandling/FlexformIrre/ActionTest.php+2 −10
- typo3/sysext/core/Tests/Functional/DataHandling/Group/Modify/ActionTest.php+21 −26
- typo3/sysext/core/Tests/Functional/DataHandling/Group/AbstractActionTestCase.php+14 −17
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/ActionTest.php+32 −37
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/AbstractActionTestCase.php+20 −23
Show 64 more files
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/ActionTest.php+38 −43
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/AbstractActionTestCase.php+22 −25
- typo3/sysext/core/Tests/Functional/DataHandling/ManyToMany/Modify/ActionTest.php+20 −25
- typo3/sysext/core/Tests/Functional/DataHandling/ManyToMany/AbstractActionTestCase.php+17 −20
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Hooks/PagesTsConfigGuardTest.php+3 −30
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+59 −64
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/MultiSite/MultiSiteTest.php+5 −15
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+16 −20
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/CheckValueTest.php+1 −6
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/CheckValueTestForCheckboxesTest.phprenamed+2 −8
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/CheckValueTestForSelectTest.phprenamed+2 −8
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/PagePermissionTest.php+1 −6
- typo3/sysext/core/Tests/Functional/DataHandling/Select/Modify/ActionTest.php+19 −24
- typo3/sysext/core/Tests/Functional/DataHandling/Select/AbstractActionTestCase.php+13 −16
- typo3/sysext/core/Tests/Functional/DataHandling/SelectFlex/Modify/ActionTest.php+1 −6
- typo3/sysext/core/Tests/Functional/DataHandling/SelectFlex/AbstractActionTestCase.php+2 −5
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperTest.php+1 −6
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperUniqueTest.php+1 −6
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+8 −50
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+3 −7
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php+2 −7
- typo3/sysext/recycler/Tests/Functional/Recycle/Pages/AdminRecycleTest.php+2 −9
- typo3/sysext/recycler/Tests/Functional/Recycle/Pages/UserRecycleTest.php+2 −9
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Discard/ActionTest.php+13 −18
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Modify/ActionTest.php+13 −18
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Publish/ActionTest.php+13 −18
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/PublishAll/ActionTest.php+13 −18
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/AbstractActionTestCase.php+2 −14
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Discard/ActionTest.php+18 −23
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Modify/ActionTest.php+17 −22
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Publish/ActionTest.php+17 −22
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/PublishAll/ActionTest.php+17 −22
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/AbstractActionTestCase.php+2 −14
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Discard/ActionTest.php+24 −29
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/ActionTest.php+24 −29
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/ActionTest.php+23 −28
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/ActionTest.php+23 −28
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/AbstractActionTestCase.php+2 −14
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Discard/ActionTest.php+24 −29
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/ActionTest.php+26 −31
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/ActionTest.php+23 −28
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/ActionTest.php+23 −28
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/AbstractActionTestCase.php+2 −14
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/ActionTest.php+20 −25
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Modify/ActionTest.php+20 −25
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Publish/ActionTest.php+20 −25
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/PublishAll/ActionTest.php+20 −25
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/AbstractActionTestCase.php+3 −15
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/ActionTest.php+56 −61
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+72 −77
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/ActionTest.php+53 −58
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/ActionTest.php+56 −61
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+8 −20
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Discard/ActionTest.php+17 −22
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Modify/ActionTest.php+17 −22
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Publish/ActionTest.php+17 −22
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/PublishAll/ActionTest.php+17 −22
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/AbstractActionTestCase.php+2 −14
- typo3/sysext/workspaces/Tests/Functional/DataHandling/SelectFlex/Discard/ActionTest.php+1 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/SelectFlex/Modify/ActionTest.php+1 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/SelectFlex/Publish/ActionTest.php+1 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/SelectFlex/PublishAll/ActionTest.php+1 −6
- typo3/sysext/workspaces/Tests/Functional/DataHandling/SelectFlex/AbstractActionTestCase.php+3 −15
- typo3/sysext/workspaces/Tests/Functional/Hook/DataHandlerHookTest.php+7 −64
Review log 57
-
Andreas Kienast commented on patch set 1 11/27/21, 18:14
Cherry Picked from branch master. -
Christian Kuhn commented on patch set 1 CR -1 11/27/21, 18:21
this has to be done on-top of a TF raise+tag - the assertCSVDataSet() method otherwise does not work as expected. let's let this backport rot a small while until this is done. -
core-ci voted on patch set 1 V -1 11/27/21, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19885
-
Christian Kuhn rebased onto patch set 2 11/27/21, 19:46
-
core-ci voted on patch set 2 V +1 11/27/21, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19893
-
Andreas Kienast voted on patch set 2 V +2 CR +2 11/27/21, 20:12
-
Andreas Kienast merged patch set 3 11/27/21, 20:13