Review 11.5 Merged

72308[BUGFIX] Fix includeCSS.inline for files with EXT: syntax

Christian Kuhn CR +2 V +2 Easy +4 −3 updated 11/27/21, 23:03

Commit message

The feature page.includeCSS.inline checks the existence
of the given file with `is_file()`. This does not work
for files included with the EXT: prefix, since the
path to the filename is not fully resolved any more
since https://review.typo3.org/c/Packages/TYPO3.CMS/+/71457

This patch processes the given file using the
`getStreamlinedFileName` function in order to resolve
the relative path to the file.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 36

  1. Christian Kuhn commented on patch set 1 11/27/21, 21:39

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V -1 11/27/21, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19901

  3. core-ci commented on patch set 1 11/27/21, 22:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19901

  4. core-ci voted on patch set 1 V +1 11/27/21, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19901

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 11/27/21, 23:03

  6. Christian Kuhn merged patch set 2 11/27/21, 23:03