Review 11.5 Merged

72420[BUGFIX] Do not add error in TypoScriptParser if modifier returns null

Christian Kuhn CR +2 V +2 Easy +16 −0 updated 12/02/21, 23:41

Commit message

Currently, the TypoScriptParser adds an error when
the result of a modifier is null. This is, because
the line is not set to a new value in such a case
and the following switch statement is not expecting
a line with a value modifier.

This has been fixed by skipping further checks on
the value, if the modifier returns null.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 12/02/21, 23:28

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/02/21, 23:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20447

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 12/02/21, 23:41

  4. Christian Kuhn merged patch set 2 12/02/21, 23:41