Review 11.5 Merged

72582[BUGFIX] Allow shortcut pages to pages of other sites

Benni Mack CR +2 V +2 Normal +211 −7 updated 12/12/21, 15:26

Commit message

TYPO3 has had a long history of linking to
other pages in other pagetrees. Most of the issues
were solved with the TYPO3 v9 Routing and Site Handling.

Through this feature, it is now possible to
easily create a page of type shortcut and link to
a page in a different page tree.

This was previously not possible because TYPO3 Core
by default generated URLs like "/index.php?id=123"
where people could simply add ?id=355 (where page 355
resides on a different page tree).

Since this change has been resolved, links to
other pages can be allowed and are automatically
redirected.

If we ever get rid of allowing to call pages with
an `?id=123` query parameter, the $pageNotFound=3 case
can be removed completely.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 57

  1. Benni Mack commented on patch set 1 12/10/21, 16:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 12/10/21, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20949

  3. Benjamin Franzke uploaded patch set 2 12/10/21, 21:45

  4. core-ci voted on patch set 2 V +1 12/10/21, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20965

  5. Stefan Bürk commented on patch set 2 V +1 CR +1 12/11/21, 14:10

    Changes from Benjamin were needed, as they where missed in the main patch (overlapping of test, merge and another patch). For main patch this was fixed with an followup by Benjamin, here he has incoorporated the changes directly.
  6. Benni Mack commented on patch set 2 V +2 CR +2 12/12/21, 15:26

    Thanks for the fix @bnf!
  7. Benni Mack merged patch set 3 12/12/21, 15:26