72582[BUGFIX] Allow shortcut pages to pages of other sites
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+34 −6
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+6 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+124 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+44 −0
Review log 57
-
Benni Mack commented on patch set 1 12/10/21, 16:23
Cherry Picked from branch main. -
core-ci voted on patch set 1 V -1 12/10/21, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20949
-
Benjamin Franzke uploaded patch set 2 12/10/21, 21:45
-
core-ci voted on patch set 2 V +1 12/10/21, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20965
-
Stefan Bürk commented on patch set 2 V +1 CR +1 12/11/21, 14:10
Changes from Benjamin were needed, as they where missed in the main patch (overlapping of test, merge and another patch). For main patch this was fixed with an followup by Benjamin, here he has incoorporated the changes directly. -
Benni Mack commented on patch set 2 V +2 CR +2 12/12/21, 15:26
Thanks for the fix @bnf! -
Benni Mack merged patch set 3 12/12/21, 15:26