Review 11.5 Merged

72586[BUGFIX] Cast $uid to int in ConditionMatcher

Oli Bartsch CR +2 V +2 Easy +1 −2 updated 12/13/21, 12:05

Commit message

With #95258 `ConditionMatcher->getPageIdByRecord()`
got type hinted. Therefore, the $uid has to be casted to
int before passing it to the method.

Additionally, a left over type cast in the method itself
is removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Oli Bartsch commented on patch set 1 12/13/21, 11:45

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 12/13/21, 11:57

  3. core-ci voted on patch set 1 V +1 12/13/21, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21022

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 12/13/21, 12:05

  5. Oli Bartsch merged patch set 2 12/13/21, 12:05