Review 10.4 Merged

72674[BUGFIX] Render hreflang only for translated pages

Benni Mack CR +2 V +2 Easy +25 −6 updated 12/15/21, 11:28

Commit message

If a language in the SiteConfig is set to the fallbackType
free and there is no translated page for this language, then
there is now no generated hreflang.

Previously, a link was always generated with default language
slug, which lead to 404 page not found.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Benni Mack commented on patch set 1 12/15/21, 07:32

    Cherry Picked from branch 11.5. The following files contain Git conflicts: * typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php * typo3/sysext/seo/Tests/Functional/Fixtures/HrefLangScenario.yml * typo3/sysext/seo/Tests/Functional/HrefLang/HrefLangGeneratorTest.php
  2. core-ci voted on patch set 1 V -1 12/15/21, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21116

  3. Stefan Bürk uploaded patch set 2 12/15/21, 07:46

  4. core-ci voted on patch set 2 V +1 12/15/21, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21118

  5. Stefan Bürk commented on patch set 2 V +1 CR +1 12/15/21, 08:02

    Re-verified in instance (patchset 2)
  6. Benni Mack marked it ready for review 12/15/21, 09:54

  7. Benni Mack voted on patch set 2 V +2 CR +2 12/15/21, 11:28

  8. Benni Mack merged patch set 3 12/15/21, 11:28