Review 11.5 Merged

72675[BUGFIX] Load all backend routes in installer controller

Benni Mack CR +2 V +2 Easy +3 −2 updated 12/15/21, 14:16

Commit message

The routes added via ExtensionManagementUtility::addModule() are missing
when the UriBuilder/Router is used prior to ext_localconf loading.

Also for this particular case, multiple instances of the Router class
were created, as UriBuilder is loaded from the failsafe installtool
container instead of using an instance from the symfony container
(as created by LateBootService n loadExtLocalconfDatabaseAndExtTables).
This resulted in multiple routers being loaded with different sets of
routes.

This patch ensures that the routes are loaded from a UriBuilder/Router
instance that is fully populated with information from ext_localconf.
Therefore GeneralUtility::makeInstance() is avoided and
UriBuilder is fetched from the late booted container instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 12/15/21, 07:37

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/15/21, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21117

  3. Benni Mack voted on patch set 1 V +2 CR +2 12/15/21, 14:14

  4. Benni Mack merged patch set 2 12/15/21, 14:16