Review 11.5 Merged

72684[BUGFIX] Avoid duplicate results in HMENU with workspaces

Benni Mack CR +2 V +2 Normal +183 −64 updated 12/16/21, 13:30

Commit message

HMENU special="directory" and special="updated" did not
use PageRepository directly, which led to duplicate
entries with workspaces.

This change does not use "$cObj->exec_..." anymore
and fixes all problems.

composer req --dev typo3/testing-framework:^6.15.2

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 57

  1. Benni Mack commented on patch set 1 12/16/21, 12:36

    Cherry Picked from branch main. The following files contain Git conflicts: * composer.lock
  2. core-ci voted on patch set 1 V -1 12/16/21, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21177

  3. Christian Kuhn uploaded patch set 2 12/16/21, 12:53

  4. Christian Kuhn commented on patch set 2 12/16/21, 12:53

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 12/16/21, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21180

  6. Benni Mack voted on patch set 2 V +2 CR +2 12/16/21, 13:30

  7. Benni Mack merged patch set 3 12/16/21, 13:30