Review 11.5 Merged

72690[BUGFIX] Avoid select and therefore fetchFirstColumn() of doctrine/dbal

Helmut Hummel CR +2 V +2 Easy +13 −27 updated 12/17/21, 15:18

Commit message

Get rid of the select query entirely, which optimises
the task to only require one update query instead of
one select and possibly multiple update queries and
gets rid of doctrine version related incompatibilities
with fetching the select result.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Helmut Hummel commented on patch set 1 12/17/21, 15:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/17/21, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21215

  3. Helmut Hummel voted on patch set 1 V +2 CR +2 12/17/21, 15:17

  4. Helmut Hummel merged patch set 2 12/17/21, 15:18