Review 11.5 Merged

72715[TASK] Avoid deprecated doctrine/dbal method 'executeUpdate()'

Benni Mack CR +2 V +2 Easy +7 −7 updated 12/20/21, 11:57

Commit message

doctrine/dbal deprecated quite some methods to cleanup
their codebase and provided replacements with more
speaking method names.

Most deprecated method usages have been replaced in
the core, but we missed some.

The patch replaces the deprecated method 'executeUpdate()'
with the corresponding 'executeStatement()' method in
several places to clean this up.

This can be done also in 11.5 too, the required minimum
version of doctrine/dbal provides these new methods as
upwards compatible layer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 58

  1. Benni Mack commented on patch set 1 12/20/21, 09:14

    Cherry Picked from branch main.
  2. Benni Mack updated the commit message in patch set 2 12/20/21, 09:15

  3. Benni Mack updated the commit message in patch set 3 12/20/21, 09:15

  4. core-ci voted on patch set 1 V +1 12/20/21, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21267

  5. core-ci voted on patch set 2 V +1 12/20/21, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21268

  6. core-ci voted on patch set 3 V +1 12/20/21, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21269

  7. Benni Mack voted on patch set 3 V +2 CR +2 12/20/21, 11:57

  8. Benni Mack merged patch set 4 12/20/21, 11:57