72716[BUGFIX] Forward-compatible prepared statement support
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+8 −7
- typo3/sysext/core/Classes/Database/Query/NamedParameterNotSupportedForPreparedStatementException.phpnew+32 −0
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+146 −1
- typo3/sysext/core/Classes/Database/Query/UnsupportedPreparedStatementParameterTypeException.phpnew+32 −0
- typo3/sysext/core/Classes/Database/Connection.php+1 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+7 −7
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/Fixtures/DataSet/queryBuilder_preparedStatement.csvnew+9 −0
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/NamedPlaceholderPreparedStatementTest.phpnew+72 −0
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/PositionPlaceholderPreparedStatementTest.phpnew+271 −0
Review log 711
-
Benni Mack commented on patch set 1 12/20/21, 14:25
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Utility/BackendUtility.php * typo3/sysext/core/Classes/DataHandling/DataHandler.php * typo3/sysext/core/Classes/Database/Connection.php * typo3/sysext/core/Classes/Database/Query/QueryBuilder.php -
core-ci voted on patch set 1 V -1 12/20/21, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21288
-
Stefan Bürk uploaded patch set 2 12/20/21, 14:48
-
core-ci voted on patch set 2 V -1 12/20/21, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21295
-
Stefan Bürk uploaded patch set 3 12/20/21, 15:02
-
core-ci voted on patch set 3 V -1 12/20/21, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21296
-
Stefan Bürk uploaded patch set 4 12/20/21, 15:28
-
core-ci voted on patch set 4 V +1 12/20/21, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21300
-
Benni Mack marked it ready for review 12/20/21, 15:45
-
Benni Mack voted on patch set 4 V +2 CR +2 12/20/21, 16:05
-
Benni Mack merged patch set 5 12/20/21, 16:05