Review 11.5 Merged

72716[BUGFIX] Forward-compatible prepared statement support

Benni Mack CR +2 V +2 Hard +578 −15 updated 12/20/21, 16:05

Commit message

doctrine/dbal:^3.2 changed return type of result for QueryBuilder
execute methods, no longer have used prepared statement accessible
for further query execution with other placeholder values.

To raise doctrine/dbal:^3.2 two places have been changed to reuse
the QueryBuilder instance itself instead of prepared statement with
the corresponding patch #96287, thus given up the performance gain
through reusable query execution plan in corresponding dbms systems.

This patch adds support for prepared statements to TYPO3's
QueryBuilder facade as this was not publicly available yet
for TYPO3 users to be forward-compatible with Doctrine DBAL 3.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 9

Review log 711

  1. Benni Mack commented on patch set 1 12/20/21, 14:25

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Utility/BackendUtility.php * typo3/sysext/core/Classes/DataHandling/DataHandler.php * typo3/sysext/core/Classes/Database/Connection.php * typo3/sysext/core/Classes/Database/Query/QueryBuilder.php
  2. core-ci voted on patch set 1 V -1 12/20/21, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21288

  3. Stefan Bürk uploaded patch set 2 12/20/21, 14:48

  4. core-ci voted on patch set 2 V -1 12/20/21, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21295

  5. Stefan Bürk uploaded patch set 3 12/20/21, 15:02

  6. core-ci voted on patch set 3 V -1 12/20/21, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21296

  7. Stefan Bürk uploaded patch set 4 12/20/21, 15:28

  8. core-ci voted on patch set 4 V +1 12/20/21, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21300

  9. Benni Mack marked it ready for review 12/20/21, 15:45

  10. Benni Mack voted on patch set 4 V +2 CR +2 12/20/21, 16:05

  11. Benni Mack merged patch set 5 12/20/21, 16:05