Review 11.5 Merged

72717[BUGFIX] Fix scoping issue in FormEngineValidation

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 12/20/21, 15:05

Commit message

theChar is not initialized and therefore pollutes global scope.
(It is assigned to window.theChar in the FormEngine iframe).

Currently not an error (we are not using strict mode in RequireJS),
just bad style, but once we switch to strict mode (type="module"),
this will fail without proper declaration.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 12/20/21, 14:37

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/20/21, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21292

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 12/20/21, 15:05

  4. Andreas Kienast merged patch set 2 12/20/21, 15:05