Review 11.5 Merged

72774[BUGFIX] Fix doctype annotations

Christian Kuhn CR +2 V +2 Easy +6 −6 updated 12/21/21, 11:25

Commit message

According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types
it is only allowed to use "string|null" and not "?string"

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 34

  1. Christian Kuhn commented on patch set 1 12/21/21, 11:09

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/21/21, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21345

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 12/21/21, 11:25

  4. Christian Kuhn merged patch set 2 12/21/21, 11:25