Review 11.5 Merged

72789[BUGFIX] Be consistent in HMENU.special = language

Benni Mack CR +2 V +2 Easy +10 −10 updated 12/23/21, 16:46

Commit message

Previously, HMENU.addQueryString, which is only
available for special=language, was applied
not within the typolink() functionality but before.

By sorting out the properties, HMENU with
special=language now properly uses typolinks
addQueryString.

Using the magic property _ADD_GETVARS to activate
this option addQueryString but also using
the "_PAGES_OVERLAY_REQUESTEDLANGUAGE" allows
to fix special=language issues.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 12/23/21, 16:21

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/23/21, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21437

  3. Benni Mack voted on patch set 1 V +2 CR +2 12/23/21, 16:46

  4. Benni Mack merged patch set 2 12/23/21, 16:46