Review 11.5 Merged

72842[BUGFIX] Use realpath() for vcsIgnore in CGL fixer

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 01/03/22, 15:40

Commit message

It seems that symfony >= 5.4.0 has a bug in symfony
finder that .gitignore files are no longer always
found when the ->in() directive is a non-absolute
path with '/../'.
This triggers issues with our cgl fixer script in
nightly mode.
We work around that by using an absolute path
instead in the configuration and will report the
issue to symfony.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 01/03/22, 15:27

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/03/22, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21568

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/03/22, 15:40

  4. Christian Kuhn merged patch set 2 01/03/22, 15:40