Review 11.5 Merged

72844[BUGFIX] Check correctly for TCA search options

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 01/04/22, 12:05

Commit message

The documentation states "case" and "pidonly" are
of type boolean. But in the code in_array was used
to decide, whether to utilize these options.

This is now fixed by checking for the array keys.

Some lines above in the first if-branch, this has
been already fixed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 01/04/22, 11:50

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/04/22, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21582

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/04/22, 12:05

  4. Christian Kuhn merged patch set 2 01/04/22, 12:05