Review 11.5 Merged

72872[BUGFIX] Do not overwrite previously set preview mode

Christian Kuhn CR +2 V +2 Easy +17 −11 updated 01/04/22, 14:52

Commit message

The frontend preview aspect may be set from the admin panel
or the frontend extension or even from a third-party extension
in a middleware. The previous implementation overwrote the preview
settings on every initialisation, resulting in lost preview
information. Instead of overwriting the setting, this change takes
the current preview value into account - if the preview was enabled
by a previous instance this is kept.

Additionally, the logic to set the preview flag in both frontend
and admin panel has been streamlined.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn commented on patch set 1 01/04/22, 14:22

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/04/22, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21590

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/04/22, 14:52

  4. Christian Kuhn merged patch set 2 01/04/22, 14:52