Review 11.5 Merged

72877[BUGFIX] Add TCA migration for select authMode keywords

Oli Bartsch CR +2 V +2 Hard +253 −5 updated 01/05/22, 10:31

Commit message

With the introduction of itemGroups, the index 3 of
the select items array has been shifted one position
to the right. Before that, the index 3 was used for
descriptions and index 4 for an optional keyword
EXPL_ALLOW or EXPL_DENY. These are used together
with authMode=individual to explicitly allow or deny
single items.

Since descriptions now occupy the index 4, the
former usage of this index needs to be shifted as
well to index 5.

For backwards compatibility reasons, a TCA migration
is added, which will check for these special
keywords and move them one index up.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 68

  1. Oli Bartsch commented on patch set 1 01/04/22, 15:57

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/04/22, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21606

  3. Oli Bartsch voted on patch set 1 V -1 CR -1 01/04/22, 16:22

  4. Oli Bartsch uploaded patch set 2 01/04/22, 16:27

  5. core-ci voted on patch set 2 V +1 01/04/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21608

  6. Christian Kuhn voted on patch set 2 CR +1 01/04/22, 17:20

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 01/05/22, 10:31

  8. Oli Bartsch merged patch set 3 01/05/22, 10:31