Review 11.5 Merged

72878[BUGFIX] Add CompositeExpression argument docblock type-hint

Benni Mack CR +2 V +2 Easy +6 −6 updated 01/05/22, 09:06

Commit message

This patch adds missing 'CompositeExpression' as union
type for QueryBuilder methods 'where()', 'andWhere()'
and 'orWhere()' to match the ability of the underlaying
doctrine/dbal QueryBuilder methods.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 01/05/22, 08:43

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/05/22, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21628

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/05/22, 09:05

  4. Benni Mack merged patch set 2 01/05/22, 09:06