Review 11.5 Merged

72881[BUGFIX] Mark shortcut pages as active in HMENU

Benni Mack CR +2 V +2 Normal +191 −46 updated 01/05/22, 12:55

Commit message

This change moves the method resolveShortcutPage()
into PageRepository as it is now also used in determining
if a page is marked as active / current.

The method `resolveShortcutPage()` is much more convenient
when working with $page records instead of the properties,
instead of `getPageShortcut()`.

This also allows MenuProcessor to have a proper "active"
and "current" values set properly without any workarounds.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 01/05/22, 12:25

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/05/22, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21641

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/05/22, 12:55

  4. Benni Mack merged patch set 2 01/05/22, 12:55