Review 11.5 Merged

72885[BUGFIX] Provide quoted array to string-list implode support

Stefan Bürk CR +2 V +2 Normal +83 −13 updated 01/05/22, 17:10

Commit message

With #96393 forward-compatible prepared statement
suport has been added, which lacks support for the
broadly known doctrine/dbal 'PARAM_STR_ARRAY' and
'PARAM_INT_ARRAY' types.

Internal methods as alternatives were introduced
as core internal methods with #92493 in the internal
'QueryHelper' class.

This patch now moves these internal implementations
to the 'QueryBuilder' to provide an forward-compatible
public alternative, which is needed to prepare statements
with 'in()' or 'notIn()' expression with array values,
which can only be used as non-placeholder, which is not
supported by PHP PDO implementation.

Further usage of internal implementation which was
introduced with #92493 are replaced with new public
methods and internal methods in QueryHelper removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 46

  1. Stefan Bürk commented on patch set 1 01/05/22, 16:19

    Cherry Picked from branch main.
  2. Stefan Bürk uploaded patch set 2 01/05/22, 16:27

  3. core-ci voted on patch set 1 V +1 01/05/22, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21657

  4. core-ci voted on patch set 2 V +1 01/05/22, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21658

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 01/05/22, 17:10

  6. Christian Kuhn merged patch set 3 01/05/22, 17:10