Review 11.5 Merged

72887[BUGFIX] Use "pages.target" properly for Pages with External URL

Benni Mack CR +2 V +2 Normal +43 −24 updated 01/05/22, 22:59

Commit message

The database field "pages.target" allows to define
a custom target attribute for links in menus of external
URLs.

Before this was (wrongly) built in HMENU but applied
after Typolink worked. This option belongs to the
actual link building when building links to external URLs
where $conf[extTarget] is evaluated.

In addition, HMENU tests now also evaluate "target"
for regular pages as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Benni Mack commented on patch set 1 01/05/22, 22:41

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php
  2. Benni Mack commented on patch set 2 01/05/22, 22:42

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 01/05/22, 22:42

  4. core-ci voted on patch set 1 V -1 01/05/22, 22:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21673

  5. core-ci voted on patch set 2 V +1 01/05/22, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21674

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/05/22, 22:59

  7. Benni Mack merged patch set 3 01/05/22, 22:59