72887[BUGFIX] Use "pages.target" properly for Pages with External URL
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+2 −13
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+4 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+4 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+33 −10
Review log 57
-
Benni Mack commented on patch set 1 01/05/22, 22:41
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php -
Benni Mack commented on patch set 2 01/05/22, 22:42
Published edit on patch set 1. -
Benni Mack marked it ready for review 01/05/22, 22:42
-
core-ci voted on patch set 1 V -1 01/05/22, 22:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21673
-
core-ci voted on patch set 2 V +1 01/05/22, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21674
-
Benni Mack voted on patch set 2 V +2 CR +2 01/05/22, 22:59
-
Benni Mack merged patch set 3 01/05/22, 22:59