Review 11.5 Merged

72912[BUGFIX] Use typolink consistently for makelinks functionality

Benni Mack CR +2 V +2 Normal +13 −39 updated 01/06/22, 15:25

Commit message

TYPO3's "makelinks" functionality parses for in-text
external URLs and mailto links. This change uses
Typolink under the hood now to consistently check
for invalid content, and have the chance to use
all hooks in typolink for such links as well.

This way, typolink is used, but makelinks is
executed AFTER possible resolved <a> tags
avoiding double-calling parseFunc when <a> tag
processing is configured.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 01/06/22, 15:12

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
  2. Benni Mack commented on patch set 2 01/06/22, 15:13

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 01/06/22, 15:14

  4. core-ci voted on patch set 1 V -1 01/06/22, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21712

  5. core-ci voted on patch set 2 V +1 01/06/22, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21713

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/06/22, 15:25

  7. Benni Mack merged patch set 3 01/06/22, 15:25