Review 11.5 Merged

72916[BUGFIX] TypoLink is executed fully without href attribute

Benni Mack CR +2 V +2 Normal +76 −31 updated 01/07/22, 11:42

Commit message

In #87992 an early return was added to have <a> tags
with just an "id" or "name" attribute. This is all nice,
but when used further typolink settings (such as userFunc
or custom "title"), these options were never run.

This change now uses typolink() natively again and
removes the introduced "resolveAnchorLinK" workaround.

Added tests show that additional attributes are executed
and links without href are actually created (was previously
untested).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 01/06/22, 23:02

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 01/06/22, 23:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21745

  3. Oli Bartsch rebased onto patch set 2 01/07/22, 11:15

  4. core-ci voted on patch set 2 V +1 01/07/22, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21759

  5. Oli Bartsch voted on patch set 2 V +2 CR +2 01/07/22, 11:42

  6. Oli Bartsch merged patch set 3 01/07/22, 11:42