72920[BUGFIX] Fix sprintf() PHP warning in FinisherOptionGenerator
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 1
Review log 56
-
Benjamin Franzke commented on patch set 1 01/07/22, 13:14
Cherry Picked from branch main. -
Benjamin Franzke voted on patch set 1 V +2 CR +2 01/07/22, 13:14
-
core-ci voted on patch set 1 V +1 01/07/22, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21771
-
Benjamin Franzke merged patch set 2 01/07/22, 13:38
-
Mathias Brodala commented on patch set 2 06/30/22, 07:29
FinisherOptionGenerator.php:82Post V-1: this is a bug since before the label was adjusted, now the value. With this change, empty fields now have a literal " [Empty]" value which is also stored upon save. -
Benjamin Franzke commented on patch set 2 08/12/22, 04:35
FinisherOptionGenerator.php:82Reply UnresolvedMay you create a ticket with a screenshot or so? Thanks.