Review 11.5 Merged

72923[TASK] Clean up Page Link Builder code

Benni Mack CR +2 V +2 Hard +239 −191 updated 01/10/22, 10:39

Commit message

During the main work of TYPO3 v9 when Site Handling
was introduced, the Page Link Builder turned into
a single monster-method.

Now, that most bugs are solved and we have a very good
test coverage for this, this change splits several
functionality into smaller methods, allowing for better
readability, extensibility and further refactoring.

Extending PageLinkBuilder now is much easier to replace
a certain part of the existing functionality (also via XCLASS).

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 01/10/22, 10:20

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/10/22, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21832

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/10/22, 10:39

  4. Benni Mack merged patch set 2 01/10/22, 10:39