Review 11.5 Merged

72928[TASK] Unify TSFE usage consistently in HMENU

Benni Mack CR +2 V +2 Easy +10 −10 updated 01/10/22, 16:39

Commit message

Some code in HMENU stems back from TYPO3 v3.x days,
and this code aims to streamline the functionality
given current functionality.

HMENU now has its own sys_page object, which should
be used. In addition, HMENU should fetch TSFE->id
consistently across all its code base.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack commented on patch set 1 01/10/22, 15:55

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/10/22, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21861

  3. Oliver Hader voted on patch set 1 CR +1 01/10/22, 16:33

  4. Benni Mack voted on patch set 1 V +2 CR +2 01/10/22, 16:39

  5. Benni Mack merged patch set 2 01/10/22, 16:39

  6. Oliver Hader voted on patch set 2 V +1 01/10/22, 16:39