Review 11.5 Merged

72973[BUGFIX] Avoid bogus title in new record controller

Andreas Kienast CR +2 V +2 Easy +7 −5 updated 01/11/22, 17:30

Commit message

NewRecordController (+ icon in doc header of list
module) renders "Create a new page" on top. This
is not a link and looks misplaced.

It is a 'section header' for optional content that can
be enabled via pageTS.

mod.wizards.newRecord.pages.show.pageSelectPosition = 1
mod.wizards.newRecord.pages.show.pageInside = 1
mod.wizards.newRecord.pages.show.pageAfter = 1

When at least one of these are enabled, the header
makes sense, but should be avoided otherwise.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 01/11/22, 16:53

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/11/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21920

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 01/11/22, 17:30

  4. Christian Kuhn merged patch set 2 01/11/22, 17:30